Canon 50mm f1.8 - I got it for about 150 dollars CAD - awesome lens, I love it so far, it's cheap and very cool. There is better out there, if you're looking for a better one. I think it's a great lens to start off with.

This is for Macro?

Also do you guys think getting a refurbished T1i is better then getting a new Xsi?

used canon 40d is best buy if you want good with little money.

50mm 1.8 is not a macro lens, its a good portrait lens that gives you good background blur. this is a fixed focal length lens not a zoom lens

if you want cheap but good macro lens i would suggest buying some used old canon fd macro lens(100 or 200mm so you dont need to be sticking your lens to things you want to shoot at(200mm gives better magnification)) and buy an adapter without glass in it(or buy one with glass and remove it). canon fd lenses need glass element in the adapter so that you can focus to infinity, and when you take the glass away you lose the infinity focus, but you can focus closer than normally. those fd lenses are manual focus, but its preferred to manual focus with macro anyway.

if you got more money to spend sigma 105mm 2.8 macro or canon 100mm 2.8(non is because with is it costs too much) would be a good choice also. with these lenses you get nice background blur for portraits also, but 100mm is bit too long for a crop sensor to be used as portrait lens(unless taking head shots only) or general lens

you cant get macro and zoom in same lens, some zoom lenses say that theyr macro, but those arent real macro lenses since they dont give 1:1 magnification. also you cant get very good image quality cheap, 50mm 1.8 is pretty good quality lens tho, but its fully plastic and makes evil noises when focusing

the 100mm 2/8 macro seems like the good choice if you want a canonlens

else the 90mm tamron 2/8 should be a good buy as well, and its a little cheaper

Agree on the 100mm macro. But if you want a cheaper alternative due to budget constraints. The can get the EF-S 60mm Macro or even cheaper, get a nifty fifty (mark I are better built with the metal mount) with a set of kenko extension tubes.

As for the used T1i vs new XSi , i agree with Antichrist- on the used 40D. Best budget/quality body.

well if he wants to shoot portrait too I guess the extra money on the 100mm is a good buy contra 60mm.

give some better working distance as well

i got the 105mm sigma macro and im very happy with it.