Here is a function we are given:

int smallest(int x, int y, int z)
{
if (x > y && x > z)
return x;
else
if (y > x && y > z)
return y;
else
if (z > x && z > y)
return z;
else
return 0;
}

I am supposed to rewrite the function without using a nested if... I'm confused by this. I feel like there are no nested ifs, though it might seem that way due to the way he indented. This is syntactically identical to:

int smallest(int x, int y, int z)
{
if (x > y && x > z)
return x;
else if (y > x && y > z)
return y;
else if (z > x && z > y)
return z;
else
return 0;
}

is it not? I'm really not sure why, but when we have an "else if" statement, my prof wants us to put the if part on the next line.

Is there a way to rewrite this without using any kind of potentially nested if statements?

Thank you.

if i understand that right you have three levels of ifs here, that is the statements '333' are nested within the '222' and those nested within the '111'

not c++ but i hope you understand anyhow:

...
int returnvalue
returnvalue=0
if (x>y && x>x) returnvalue=x end
if (y>x && y>z) returnvalue=y end
if (z>x && z>y) returnvalue=z end
return returnvalue
..

this is without nested ifs, just ensure that you put it into proper c++ form

in the C family there is no such thing as "else if". your prof is correct, they are nested if statements.

brmv's answer should be sufficient. alternatively, you can compare each value only once:

int smallest = x;
if (smallest > y) smallest = y;
if (smallest > z) smallest = z;


/edit1: why is your function called "smallest" if it returns the largest?

This post was edited by carteblanche on Oct 9 2013 11:36pm

So does "else if" imply a nested if?

Your function does make sense though. Does the "end" just break the if statement?

I guess I could just write something like:

int smallest(int x, int y, int z)
{
if (x > y && x > z)
return x;
if (y > x && y > z)
return y;
if (z > x && z > y)
return z;
}




Ohh, that's a good way to do it too, thanks.

I also just realized my indentations in my first post didn't work

This post was edited by smashT on Oct 9 2013 11:35pm

use the [code] blocks for indentations

and make sure your function either uses >= or default method in case more than 1 value is the smallest

Yeah thanks, it is supposed to return 0 if none of the other statements are true. I didn't add that in my first reply. And it definitely needs a new name...

@ edit 1 - agreed, except for the case that there are two or three equally large
@ edit 2 - it seems that the code is to return 0 if there is no largest

and @ op: yes, the 'end' is there to indicate that the if statement is finished
as said, i never used c++ so you need to put it into the correct form

This post was edited by brmv on Oct 9 2013 11:45pm

Yeah thanks, I think your first solution will work fine.

I have several versions of the same code all compiling and performing properly, so I think I've got it figured out.

Thanks to both of you guys.