Just wondering if there are any other professions that personally benefit my character for having the profession ?

Like

Alchemy:
Potions last twice as long

Engineering:
Nitro Boost
Mobile Mail
Mobile Banker


Any others you guys can think of currently in legion? thanks

Not particularly. I always just do Engineering for the huge convenience and Jewelcrafting for prospecting.

Tailors get extra cloth loot which is a little money..... Basically nothing though.

Enchanting is the best for passive gold with disenchanting bops. Huge at the beginning of any expac and pretty good if you farm old runs a lot, saves bag space on old runs too.

I am reworking my toons to have all professions and have them distributed such that a clothie can tailor the bop tailoring items, a leather/chain each on leatherworking and a plate on blacksmithing just to get all transmogs.. So there is that. But its not a high priority even for me with so many other grinds to focus on. Materials for those bops can take a really long time or a ton of money to get on top of the levelling to 700+.