enchanting is always nice

so is jewelcrafting

Every profession makes gold. Impossible to tell the best for you since don't know about your skillset and time you want to invest etc. It'll never ever match shopping spree on AH though.

yeah this!

Enchanting- Doesn't fall off late in expansions can shard all your lfr gear you get from doing legendary quests. Old enchants sell, enchants for alts sell,late into expansions everyone's looking to enchant their alts
Tailoring-Extra cloth drops , bags always sell this combined with enchanting you with have the dust you need to make them as well

I'm Enchanting/Jewelcrafting on my Resto shaman

for the socket+enchant

if that is still a thing ofc