I need to find a way to validate the users input in the constructor/class rather than the main()
the area i need to validate is the ::setDay. I tried using a for(;;) around the for loop with an if statement nested in it but couldnt get it to work out. any ideas?
dayType.h



main.cpp

It seems to work for me on cpp.sh

Make sure you're typing the days of week with a capital letter just as you did in your constructor.

edit: Just as a tip, I'd avoid using 'break' as it is considered bad practice. Structure your loops to avoid it, such as:



Also, avoid system("pause). There are settings to keep your terminal open to read it so you don't have to clutter your code with pauses.

This post was edited by PureOwnage2 on Mar 28 2016 01:37pm

I haven't heard that before. Is that just a c++ thing? It's good practice in the other languages in familiar with

This post was edited by carteblanche on Mar 28 2016 02:27pm

After googling around and seeing what the gurus of stack overflow had to say (lmao), it seems that breaks aren't a bad practice like I was taught. The issue that my professors always had with it is that it is easy to lose track of the purpose of breaks in multiple nested loops. When you start putting breaks and gotos everywhere, you're obstructing the flow of logic making it unreadable. So, I guess they're good and bad on a case by case basis. If they're used in a concise way, they're fine. I guess my professors just spoke too much in absolutes. They probably just wanted to avoid reading spaghetti code Also, they probably spoke in absolutes in order to force us to learn the concepts behind different loops. Otherwise, we'd have some assembly-type c++ code that is terrible to read. To avoid using breaks, I've always used something like



But, the system pause thing is something I was always taught too. Sigh... guess I gotta go find out if that is nonsense too.

edit: It seems that system pause is generally frowned upon as it is platform specific and generally an insecure way of allowing you to read your ouput. Consider using a breakpoint and then debug from there. In case anyone reads this and was wondering, I'll save you the google.

This post was edited by PureOwnage2 on Mar 28 2016 02:55pm

Deliberately setting a variable solely to exit out of the loop is a terrible idea. It's less readable,can have side effects, and can involve adding extra variables in cases where you can't easily manipulate the condition.

For example, how would you break out of this loop without a break?



Not so easy to manipulate the condition, so you'd go out of your way to make it less readable

What about just changing that if statement within the setDay func to a while loop and remove the break? My data structures professor would throw a fit if we used break outside of switch statements. I think that's still ingrained unfortunately lol.

Thanks for reviving a long dead thread just to insert you 2cents.

Anytime bud!