I don't get why this isn't working...I just created a simple form for people to enter their height/weight into and it will convert it into cm/kg...but when I click the button nothing is happening and I'm utterly confused as to why


<form name="calculator" method="post" action="">
<p>
<label for="height">Height(in)</label>
<input type="text" name="height" id="height" /> <span id="result1"> </span>
</p>
<p>
<label for="weight">Weight(lbs)</label>
<input type="text" name="weight" id="weight" /> <span id="result2"> </span>
</p>
<input type="button" name="calculate" value="Calculate" id="calculate"/>
</form>


<script type="text/javascript">
var btn = document.getElementById('calculate');
btn.onclick = function() {

var he = parseInt(document.getElementById('height').value);
var we = parseInt(document.getElementById('weight').value);

var result1 = document.getElementById('result1');
var result2 = document.getElementById('result2');
var error = [];
if(isNaN(he)){
error.push('Please enter a number into height field');
}
if(isNan(we){
error.push('Please enter a number into weight field');
}
if(error.length > 0) {
result1.innerHTML = error.join(', ');
}
else {
result1.innerHTML = 'Your height in CM is: ' + he * 2.54;
result2.innerHTML = 'Your weight in KG is: ' + we * 0.453592;
}
};
</script>

This post was edited by Hypertrophy on Dec 1 2012 06:07pm

im not big on js so i dont know when that script block gets executed. i would try setting the onclick method directly inside the html control, defining the function in the header, and remove the method=post on the form.

This post was edited by carteblanche on Dec 1 2012 06:25pm

I fixed it -.- the second if(isNaN) the second N wasn't capitalized -.- this is why I despise any type of programming lol

shouldn't you get an error when functions dont exist?

Not when you're editing in notepad++ I guess :/ I'm sure if I was using VIM or something it would post an HTTPerror

I just figured the logic was off somewhere, so I hadn't checked httperrors on the server

This post was edited by Hypertrophy on Dec 1 2012 06:14pm

IDE should have nothing to do with it unless you mean a tool that checks for functions/syntax/etc. i was referring to the browser. i figured you'd see a message (possibly via firebug) that a function didnt exist

ah yah our babbage server has an httperrors tool that would probably post it, but running it in chrome it just ignored it and when clicking the calculate button nothing would happen

You need to use document.ready before executing the script, or else the script will execute before the html finishes rendering...

yep.



This post was edited by PixileDust on Dec 1 2012 07:30pm